Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump CL, EFO, HsapDv, MmusDv, MONDO, UBERON ontology versions for CxG schema 5.2.0 #217

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

nayib-jose-gloria
Copy link
Collaborator

@nayib-jose-gloria nayib-jose-gloria commented Aug 19, 2024

Reason for Change

Testing steps

  • unit tests

Notes for Reviewer

  • First-time Reviewers: I made commit 7a9e06a, which indicated the ontology versions associated with schema 5.2.0. This commit triggered an automated GHA that fetches, parses the new ontologies for pertinent info, and commits the new ontology assets as a new commit 6bb6dfb
  • We use docstring tests in this package that rely on reading real data from the latest ontologies; in this case, the 'description' of one of the example terms we use for this test changed between ontology versions, so I updated the test accordingly.
  • After this PR is merged, release-please will create a new PR bumping the package version; merging that subsequent PR will create a new release of cellxgene-ontology-guide in PyPI, which will now support parsing the ontology versions associated with schema 5.2.0
  • For a migration, we will then bump the cellxgene-ontology-guide version in single-cell-curation (and, eventually, single-cell-data-portal) to use schema 5.2.0 ontologies when validating / processing datasets.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (b56bb90) to head (b362643).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          18       18           
  Lines        1128     1128           
  Branches      220      220           
=======================================
  Hits          965      965           
  Misses        153      153           
  Partials       10       10           
Flag Coverage Δ
unittests 85.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayib-jose-gloria nayib-jose-gloria marked this pull request as ready for review August 23, 2024 15:58
@nayib-jose-gloria nayib-jose-gloria merged commit 5bb43b9 into main Sep 4, 2024
11 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/bump-ontologies branch September 4, 2024 18:01
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants