runners: Use ubuntu version as an argument #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding version 20.04, use the argument UBUNTU_VERSION and default to "focal" (e.g 20.04). All depedencies accept both 20.04 and focal as a tag to the same container. Signed-off-by: Manu Bretelle <[email protected]>
chantra
force-pushed
the
use_version_as_arg
branch
8 times, most recently
from
97d8004 to
4ef63b6
Compare
We can now pass a custom UBUNTU_VERSION value to build a specific version of the container. The name of the container needs to be changed to account for the version name. Signed-off-by: Manu Bretelle <[email protected]>
chantra
force-pushed
the
use_version_as_arg
branch
2 times, most recently
from
5b8968f to
845e5fa
Compare
The tooling currently expect a tag of {branch}-{arch}.
Previous diff changed this to {branch}-{ubuntu_version}-{arch}.
This change also add the old tag format when building for focal, this way we
won't have to change the tooling while transitioning.
Signed-off-by: Manu Bretelle <[email protected]>
chantra
force-pushed
the
use_version_as_arg
branch
from
845e5fa to
153cd9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding version 20.04, use the argument UBUNTU_VERSION and default to "focal" (e.g 20.04). All depedencies accept both 20.04 and focal as a tag to the same container.