Bug: fixing collisionreport data #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getBody0()` returns an object, therefore `_objects_ammo[ manifold.getBody0() ];` results in `NaN` in report-data. Using ammo-js v0.0.2 and chrome v43.0.2357.134
|
God. I was just struggling with this for way too long. I think this happens with an updated version of Ammo.js. Replacing with the |
|
I also spent a while tracking this issue down... What is holding back this patch? To avoid breaking examples using an older ammo.js, would it be better to make it backwards compatible? eg. This also fixes issue #220. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBody0()returns an object, therefore_objects_ammo[ manifold.getBody0() ];results inundefined, and as reportdata is Float32Array, we end up withNaNin report data.Using ammo-js v0.0.2 and chrome v43.0.2357.134