Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trim, ltrim, rtrim functions #512

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Conversation

agonist
Copy link
Contributor

@agonist agonist commented Nov 17, 2023

Add the trim function and its 2 variants ltrim rtrim.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (c0397ab) 79.03% compared to head (551fd6e) 78.94%.

Files Patch % Lines
internal/expr/functions/strings.go 60.00% 15 Missing and 3 partials ⚠️
internal/expr/functions/definition.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   79.03%   78.94%   -0.09%     
==========================================
  Files         126      126              
  Lines       10840    10890      +50     
==========================================
+ Hits         8567     8597      +30     
- Misses       1555     1571      +16     
- Partials      718      722       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@asdine asdine merged commit 6dc2964 into chaisql:main Nov 18, 2023
1 of 3 checks passed
@asdine asdine added this to the v0.16.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants