Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOWER builtin function #510

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

agonist
Copy link
Contributor

@agonist agonist commented Nov 17, 2023

Adds LOWER to builtins functions to format TEXT fields to lower-case.

For non TEXT fields it will return NULL.

Types that can be casted to TEXT will work if they're first explicitly casted.

Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @agonist !

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f94c703) 79.09% compared to head (b00e4ea) 79.04%.

❗ Current head b00e4ea differs from pull request most recent head 53799fe. Consider uploading reports for the commit 53799fe to get more accurate results

Files Patch % Lines
internal/expr/functions/builtins.go 57.14% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
- Coverage   79.09%   79.04%   -0.05%     
==========================================
  Files         125      125              
  Lines       10795    10816      +21     
==========================================
+ Hits         8538     8550      +12     
- Misses       1541     1549       +8     
- Partials      716      717       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asdine asdine merged commit b034800 into chaisql:main Nov 17, 2023
1 check passed
@asdine asdine added this to the v0.16.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants