[Test] Use Unix sockets for reliability #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver creation This commit introduces several improvements to server creation: - Added a generic `create_grpc_server` function that supports both TCP and Unix socket servers - Created a `ServerAddr` enum to handle different address types - Implemented Unix socket server creation methods for verifier, operator, aggregator, and watchtower - Updated test utilities to use Unix sockets for inter-service communication - Added shutdown channel support for graceful server termination The changes provide more flexibility in server configuration and improve testing capabilities by allowing Unix socket communication.
…l support This commit improves the RPC client connection mechanism: - Updated `get_clients` function to support both TCP and Unix socket connections - Modified client connection methods to use Hyper and Tokio for more flexible networking - Refactored client initialization to use channel-based connections - Updated test utilities to use the new generic client connection method - Added support for Unix socket paths in endpoint configuration
|
It seems that unix sockets are slightly slower in our case. Not sure why, but this PR is still a must-have since it fixes flaky tests. |
mmtftr
changed the title
mmtftr
changed the title
mmtftr
requested review from
ceyhunsen and
ekrembal
and removed request for
ceyhunsen
ekrembal
approved these changes
Feb 28, 2025
Windows will not be able to run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tests are flaky due to the many ports we allocate for each test with actors. TCP has an overhead and is quite a lot slower when bound by bandwidth. More importantly, due to the increasingly parallelized tests, we have flaky tests due to port collisions when allocating ports.
This PR migrates the random TCP port allocation to random Unix socket allocation by generalizing connection primitives and refactoring test utils
Linked Issues
Testing
The tests must execute without flakiness
Docs
Docs have been updated for test utils.