Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deposit and withdrawal at Citrea #570

Merged
merged 26 commits into from
Mar 4, 2025
Merged

Make deposit and withdrawal at Citrea #570

merged 26 commits into from
Mar 4, 2025

Conversation

ceyhunsen
Copy link
Member

@ceyhunsen ceyhunsen commented Feb 26, 2025 •
edited
Loading

Description

  • Adds Citrea deposit test functions
  • Adds Citrea withdrawal test functions

Re-open of #550

Tests

  • Moves out Bitcoind creation from create_actors because we need to use citrea-e2e's Bitcoind in new tests

Linked Issues

@ceyhunsen ceyhunsen mentioned this pull request Feb 26, 2025
Closed
ceyhunsen and others added 15 commits March 3, 2025 10:20
@ceyhunsen
test: Add common citrea code.
0327ee8
@ceyhunsen
tests: Don't spawn new regtest in create_actors.
1741652
@ceyhunsen
tests: Add regtest spawner to 2 tests.
239f4fa
@ceyhunsen
tests(deposit): Add asserts to deposittocitrea test.
81ea160
@ceyhunsen
test: Add initial deposit test.
6966e83
@ceyhunsen
tests(withdraw): Make 2 deposits.
4fe5a6c
@ceyhunsen
test(withdraw): Create withdrawal tx for evm.
aeab4cf
@ceyhunsen
test(withdraw): Refactor bits.
ca2e786
@ceyhunsen
chore(test/citrea): Move citrea_url config change to update_config_wi…
143ede6 
…th_citrea_e2e_da and remove deposit code in citrea_withdraw test.
@ceyhunsen
test(withdraw): Add/improve withdraw related calls.
5022dd2
@ekrembal @ceyhunsen
Some improvments (#574)
783929d 
* Some improvments

* Succesfully make a withdrawal
@ceyhunsen
test(utils): Revert changes in generate_withdrawal_transaction_and_si…
49a8b76 
…gnature.
@ceyhunsen
tests(citrea): Define more constants.
da79cc6
@ceyhunsen
tests(citrea): Reuse sol types defined in json.
7bc8bed
@ceyhunsen
fix(test/utils): Remove erpc creation from create_actors.
a6e0b62
@ceyhunsen ceyhunsen force-pushed the ceyhun/citrea_withdrawal branch from f4727a1 to a6e0b62 Compare March 3, 2025 07:38
@ceyhunsen ceyhunsen mentioned this pull request Mar 3, 2025
Open
@ceyhunsen ceyhunsen marked this pull request as ready for review March 3, 2025 12:44
@ceyhunsen ceyhunsen requested review from ekrembal, jfldde and mmtftr March 3, 2025 12:44
atacann
atacann reviewed Mar 3, 2025
View reviewed changes
core/src/test/common/citrea/bitcoin_merke.rs Outdated
@@ -0,0 +1,174 @@
use serde::{Deserialize, Serialize};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in file name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f910f35

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merke is a good name :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverse of ekrem

@ceyhunsen ceyhunsen requested a review from ekrembal March 3, 2025 16:03
@ceyhunsen ceyhunsen merged commit 1ef0f61 into dev Mar 4, 2025
9 checks passed
@ceyhunsen ceyhunsen deleted the ceyhun/citrea_withdrawal branch March 4, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atacann atacann atacann left review comments

@jfldde jfldde Awaiting requested review from jfldde

@mmtftr mmtftr Awaiting requested review from mmtftr

@ekrembal ekrembal Awaiting requested review from ekrembal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceyhunsen @ekrembal @atacann