Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database crate simplification #330

Merged
merged 20 commits into from
Oct 10, 2024
Merged

Database crate simplification #330

merged 20 commits into from
Oct 10, 2024

Conversation

ceyhunsen
Copy link
Member

@ceyhunsen ceyhunsen commented Oct 2, 2024 •
edited
Loading

Description

This PR removes redundant code and simplifies database crate:

  • Verifier and operator specific database layers removed
  • PostgreSQL related stuff moved to mod.rs
  • Some of the functions are marked as private to be only used internally

Linked Issues

Testing

Added new tests.

@ceyhunsen ceyhunsen changed the title Database overhaul Database crate simplification Oct 2, 2024
@ceyhunsen ceyhunsen marked this pull request as ready for review October 2, 2024 14:01
ekrembal
ekrembal requested changes Oct 2, 2024
View reviewed changes
@ceyhunsen ceyhunsen requested a review from ekrembal October 2, 2024 14:18
@ekrembal ekrembal merged commit 38dfdea into main Oct 10, 2024
11 checks passed
@ekrembal ekrembal deleted the ceyhun/db_overhaul branch October 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekrembal ekrembal ekrembal approved these changes

@ozankaymak ozankaymak ozankaymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceyhunsen @ekrembal @ozankaymak