-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite db & storage #1880
Merged
yaziciahmet
merged 46 commits into
nightly
from
yaziciahmet/rewrite-prover-storage-manager
Feb 15, 2025
Merged
Rewrite db & storage #1880
yaziciahmet
merged 46 commits into
nightly
from
yaziciahmet/rewrite-prover-storage-manager
Feb 15, 2025
+814
−3,325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5817089
to
729836a
Compare
eyusufatik
reviewed
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really a detailed review just peeked over the changes
crates/sovereign-sdk/module-system/sov-modules-api/src/containers/mod.rs
Outdated
Show resolved
Hide resolved
eyusufatik
requested changes
Feb 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits. well done.
crates/sovereign-sdk/full-node/db/sov-schema-db/src/transaction.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-state/src/prover_storage.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-state/src/prover_storage.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/module-system/sov-state/src/prover_storage.rs
Outdated
Show resolved
Hide resolved
crates/sovereign-sdk/full-node/sov-prover-storage-manager/src/lib.rs
Outdated
Show resolved
Hide resolved
eyusufatik
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial rewrite of the storage system. Here is an overview of changes made:
One side-note that is rather important is that, before, we were committing state db versions as block + 1. so the block 1 would be version 2 in the db. But weirdly, native db was such that block 1 is committed as version 1. This pr changes that and makes native db block 1 to be version 2 (+1). IT IS BREAKING CURRENT NODES. But it is stupid to have such difference, and I think it is something worth to resync native db.
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?