Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gravity-Bridge currencies #528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChristianBorst
Copy link

No description provided.

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 1:51pm

@HeesungB
Copy link
Collaborator

@ChristianBorst Hello.
It must first be added to currencies in order to be added to fee currencies.

@ChristianBorst
Copy link
Author

@HeesungB I have fixed the discrepancies, hopefully the Github Actions succeed this time.

@ChristianBorst
Copy link
Author

Hello @HeesungB , it appears that the validation check for Gravity-Bridge currencies is the limiter here. We explicitly want bridged currencies to appear in the wallet as having a value, e.g. USDC should always display around $1 US in value. To accomplish this, I have removed this check from src/validate.ts:

    if (currency.coinMinimalDenom.startsWith("gravity0x")) {
      throw new Error(
        `Do not provide bridged currency to currencies: ${currency.coinMinimalDenom}`,
      );
    }    

I am happy to work with you on this if there is a better way.

@HeesungB
Copy link
Collaborator

HeesungB commented Apr 3, 2024

@ChristianBorst Could you resolve conflict?

@ChristianBorst
Copy link
Author

@HeesungB The conflict should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants