Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tiny issue #5

Merged
merged 1 commit into from
Jul 13, 2024
+5 −2
Merged

fix tiny issue #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/foundry/foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@ zero-sepolia = "${ZERO_SEPOLIA_RPC}"

[etherscan]
sepolia = { key = "${SEPOLIA_API_KEY}", url = "https://api-sepolia.etherscan.io/api" }
# base-sepolia =
# arbitrum-sepolia =
# scroll-sepolia =

# See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options
4 changes: 2 additions & 2 deletions packages/foundry/src/Notes.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ contract Notes {
}

// Instantiate new a new NoteScore datatype
CNDataTypes.NoteScore newScore;
CNDataTypes.NoteScore memory newScore;

// Set the calculated score
newScore.score = score;
Expand All @@ -132,7 +132,7 @@ contract Notes {
// And if so toggle the status
newScore.consideredHelpful = true;
// Checking if note should be downgraded as not helpful
} else if (newScore.consideredHelpful && score < 10 %% totalVotes > 10 ) {
} else if (newScore.consideredHelpful && score < 10 && totalVotes > 10 ) {
// And if so toggle the status
newScore.consideredHelpful = false;
}
Expand Down
Loading