Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature refactor llm function package #200

Merged
merged 16 commits into from
Dec 19, 2024
Merged

Feature refactor llm function package #200

merged 16 commits into from
Dec 19, 2024

Conversation

Winston-503
Copy link
Contributor

@Winston-503 Winston-503 commented Dec 12, 2024 •
edited
Loading

  • Split llm into llm/base and llm/llm_function packages
  • Implement LLMFunctionWithPrompt.from_configs() and LLMFunctionWithPrompt.string_from_configs()
  • Add unit test for new from_configs()

@Winston-503 Winston-503 marked this pull request as ready for review December 16, 2024 18:44
@Winston-503
Update ruff version
dbea7e9
@Winston-503
Merge branch 'main' into feature-refactor-llm-function-package
d4f2f23 
# Conflicts:
#	tests/unit/llm/test_llm_consumption_calculators.py
@Winston-503
Merge branch 'main' into feature-refactor-llm-function-package
e9e78c8 
# Conflicts:
#	council/llm/base/providers/ollama/ollama_llm_configuration.py
#	council/llm/base/providers/openai/azure_chat_gpt_configuration.py
aflament
aflament approved these changes Dec 19, 2024
View reviewed changes
tests/unit/__init__.py
@@ -1,4 +1,4 @@
class LLModels:
class LLMModels:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Winston-503 Winston-503 merged commit 3e6d1f3 into main Dec 19, 2024
5 checks passed
@Winston-503 Winston-503 deleted the feature-refactor-llm-function-package branch December 19, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aflament aflament aflament approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Winston-503 @aflament