Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Python 2 in the Makefile #31

Merged
merged 2 commits into from
Jul 26, 2016
Merged

Pin to Python 2 in the Makefile #31

merged 2 commits into from
Jul 26, 2016

Conversation

chadwhitacre
Copy link
Owner

I have python as Python 3 on my system, so make env creates a Python 3 virtualenv. We're blocking on Aspen/Pando (AspenWeb/pando.py#493) to upgrade to Python 3, so for now let's enforce Python 2.

Look okay, @jaraco?

We're blocking on Aspen/Pando to upgrade to Python 3.
@jaraco
Copy link
Collaborator

jaraco commented Jul 26, 2016

On my system, I have virtualenv installed only in Python 3, so make wouldn't have worked for me anyway. What about instead python virtualenv --python python2.7? That should work and enforce the target python.

This way the parent Python can be either 2 or 3.
@chadwhitacre
Copy link
Owner Author

Good idea. Working on my system in 9d0fb6e. 👍

May I invite you to merge this PR if you are so inclined? :-)

@jaraco jaraco merged commit 280e61b into master Jul 26, 2016
@jaraco
Copy link
Collaborator

jaraco commented Jul 26, 2016

Happy to. Thanks for sharing the experience.

@chadwhitacre chadwhitacre deleted the pin-to-python2 branch July 26, 2016 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants