Fix angular-busy promise-compare issues and added UT #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related also to issue #68
In case I change cg-busy unresolved promise with a new unresolved promise - the tracker.reset is not begin called.
This is due the use of angular.equals, which doesn't look on "$" fields - so the two above promises looks the same.
Because reset is not being called, when the first promise is resolved - the cg-busy overlay is removed, which causes unwanted behaviour (the user still waits for an action, but no overlay).
Therefore, we add to the promise object a random ID, so comparison works correctly.
Added also UT that catch this bug, and works after our fix.
Thanks to @barnash for the help in debugging and finding a solution for it.