fix: Ignore invalid xcframework paths #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/fix-warnings-for-multi-xcframeworks
branch
2 times, most recently
from
59ce227 to
cd507b3
Compare
cgrindel
reviewed
Jan 13, 2025
luispadron
force-pushed
the
luis/fix-warnings-for-multi-xcframeworks
branch
from
cd507b3 to
b56b770
Compare
luispadron
changed the title
cgrindel
approved these changes
Jan 14, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b194745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules should ignore invalid
.xcframeworkpaths like SPM does (see here). Unlike SPM however, in Starlark we do not have a readily available.plistdecoder so we will simply ensure that anInfo.plistfile exists and let the build rules handle potential issues.This fixes cases where I was getting warnings because our .zip file contains a
__MACOSXdirectory that contains a.xcframeworkdirectory (this is used for metadata by macOS). All the files are prefixed with._so the Info.plist check here fixes including these bad paths in our search.