Formatting and minor bug fix

cgivre · Aug 5, 2024 · f372ad6 · f372ad6
1 parent c959d76
commit f372ad6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkGroupScan.java b/contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkGroupScan.java
@@ -321,16 +321,10 @@ private String generateQuery() {
     // default time boundaries in the config.  These will be overwritten in filter pushdowns
     if (filters != null && filters.containsKey(SplunkUtils.EARLIEST_TIME_COLUMN)) {
       earliestTime = filters.get(SplunkUtils.EARLIEST_TIME_COLUMN).value.value.toString();
-
-      // Remove from map
-      filters.remove(SplunkUtils.EARLIEST_TIME_COLUMN);
     }
 
     if (filters != null && filters.containsKey(SplunkUtils.LATEST_TIME_COLUMN)) {
       latestTime = filters.get(SplunkUtils.LATEST_TIME_COLUMN).value.value.toString();
-
-      // Remove from map so they are not pushed down into the query
-      filters.remove(SplunkUtils.LATEST_TIME_COLUMN);
     }
 
     if (earliestTime == null) {
@@ -355,7 +349,6 @@ private String generateQuery() {
     if (filters != null && filters.containsKey("sourcetype")) {
       String sourcetype = filters.get("sourcetype").value.value.toString();
       builder.addSourceType(sourcetype);
-      filters.remove("sourcetype");
     }
 
     // Add projected columns, skipping star and specials.

diff --git a/...b/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkPluginConfig.java b/...b/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkPluginConfig.java
@@ -327,9 +327,9 @@ public String toString() {
       .field("earliestTime", earliestTime)
       .field("latestTime", latestTime)
       .field("Authentication Mode", authMode)
-        .field("maxColumns", maxColumns)
-        .field("maxCacheSize", maxCacheSize)
-        .field("cacheExpiration", cacheExpiration)
+      .field("maxColumns", maxColumns)
+      .field("maxCacheSize", maxCacheSize)
+      .field("cacheExpiration", cacheExpiration)
       .toString();
   }
 

diff --git a/...rage-splunk/src/test/java/org/apache/drill/exec/store/splunk/SplunkLimitPushDownTest.java b/...rage-splunk/src/test/java/org/apache/drill/exec/store/splunk/SplunkLimitPushDownTest.java
@@ -64,6 +64,7 @@ public void testLimitWithFilter() throws Exception {
       .sql(sql)
       .planMatcher()
       .include("Limit", "maxRecords=4")
+      .include("spl", "search index=_audit rating=52.17 | fields rating | head 5 | table rating")
       .match();
   }
 }