Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyetracker-Interface for WebGL-Operate #235

Merged
merged 16 commits into from
Mar 4, 2020
Merged

Eyetracker-Interface for WebGL-Operate #235

merged 16 commits into from
Mar 4, 2020

Conversation

p-otto
Copy link
Collaborator

@p-otto p-otto commented Feb 28, 2020

This PR adds an EyeEventProvider which connects to the running Eye Tracking Server via a WebSocket and provides the results as Events. Additionally, it refactors the mouseeventprovider, etc. into one plain object in order to have named arguments.

NOTE:
Sadly I cannot reproduce the CI errors locally.

@MartinBuessemeyer MartinBuessemeyer changed the title WIP: Eyetracker Eyetracker-Interface for WebGL-Operate Feb 29, 2020
@coveralls
Copy link

coveralls commented Mar 2, 2020

Coverage Status

Coverage decreased (-0.5%) to 17.505% when pulling 7dc5083 on eyetracker into ad7d5f6 on master.

@p-otto
Copy link
Collaborator Author

p-otto commented Mar 2, 2020

@MartinBuessemeyer I fixed the CI errors and a copy paste error. The PR looks good for the most part to me. A few things:

  1. There are some TODOs in eyegazeevent.ts, are these resolved and if not are they important enough to open issues for them?
  2. There are console.log calls in eyegazedatastream. We should remove them or replace them with auxiliary.log if they are important.
  3. The websocketAddress in eyegazedatastream.ts is currently hardcoded, this should instead be set by the renderer.
  4. The demo should be disabled in demos.json for now, as it is not useful to users without access to an eyetracking setup

@MartinBuessemeyer
Copy link
Collaborator

  1. I opened one issue in this repo: Add eye tracking track box  #237
  2. The console prints are not necessary anymore. Therefore I just removed them.
  3. Done.
  4. I added an optional argument that is forewarded to the connect method.
  5. resovled merge conflicts with master.

@cgcostume cgcostume merged commit 7ac8c48 into master Mar 4, 2020
@cgcostume cgcostume deleted the eyetracker branch March 4, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants