Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements #2152

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Test improvements #2152

merged 4 commits into from
Mar 21, 2024

Conversation

kuhnroyal
Copy link
Member

  • move some tests from http2/dio to shared test project
  • add some new tests for validateStatus
  • wrap SocketException in DioExceptionType.connectionError instead of DioExceptionType.unknown in the Http2Adapter -> this brings the behavior in line with the default adapters

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal added the e: tests Improvements or additions to tests label Mar 20, 2024
@kuhnroyal kuhnroyal self-assigned this Mar 20, 2024
Copy link
Contributor

Code Coverage Report

Package Base Coverage New Coverage Difference
dio 🟢 80.34% 🟢 81.09% 🟢 0.75%
Overall Coverage 🟢 80.34% 🟢 81.09% 🟢 0.75%

Minimum allowed coverage is 0%, this run produced 81.09%

@kuhnroyal kuhnroyal marked this pull request as ready for review March 20, 2024 22:00
@kuhnroyal kuhnroyal requested a review from a team as a code owner March 20, 2024 22:00
@kuhnroyal
Copy link
Member Author

We now have the comment working. Thanks to @tm1000 for merging and releasing clearlyip/code-coverage-report-action#50!

@AlexV525
Copy link
Member

Wonderful, thanks for your great work @kuhnroyal @tm1000

@kuhnroyal kuhnroyal added this pull request to the merge queue Mar 21, 2024
Merged via the queue into cfug:main with commit 95d1fa4 Mar 21, 2024
3 checks passed
@kuhnroyal kuhnroyal deleted the test/improvements branch March 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: tests Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants