Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Styling] Use CFPB Colors in Tailwind Theme #1112

Merged
merged 5 commits into from
Feb 4, 2025
Merged

[Styling] Use CFPB Colors in Tailwind Theme #1112

merged 5 commits into from
Feb 4, 2025

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Jan 21, 2025 •
edited
Loading

Find hardcoded colors and replace them to use tailwind theme colors

Changes

  • Updated locations of hardcoded colors to take advantage of tailwind styles instead

How to test this PR

Setup for verification

  • Perform any console commands below from within the sbl-frontend directory
  1. Run checkout main && git pull
  2. Restart the stack
  3. Run yarn run test:e2e:snapshot-update
  4. Once finished ctrl-c
  5. Run git add --all
  6. Run git stash
  7. Run git checkout 1094-tailwind-theme && git pull
  8. Run git stash pop
  9. Restart the stack

Verify the changes

  1. Run yarn run test:e2e:snapshot
  2. In the playwright testing window that appears, run all tests
  3. Verify that there are no relevant snapshot related failures
  4. Click through the site and verify that things look as they should

@tanner-ricks tanner-ricks marked this pull request as ready for review January 24, 2025 17:37
@tanner-ricks tanner-ricks linked an issue Jan 24, 2025 that may be closed by this pull request
[Styling] Use CFPB Colors in Tailwind Theme #1094
Closed
meissadia
meissadia approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏾

@tanner-ricks tanner-ricks merged commit 89c5343 into main Feb 4, 2025
11 checks passed
@tanner-ricks tanner-ricks deleted the 1094-tailwind-theme branch February 4, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Styling] Use CFPB Colors in Tailwind Theme
2 participants
@tanner-ricks @meissadia