Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snake CVE #4837

Merged
merged 16 commits into from
Aug 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update deployment yamls for ratespread-calculator and data browser to…
… fix helm errors and warnings
rkovalik-raft committed Aug 13, 2024
commit a3af8b97badb2233f8a900f96d6e9141ba995337
32 changes: 0 additions & 32 deletions kubernetes/hmda-data-browser-api/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -160,38 +160,6 @@ spec:
key: aws-region
- name: BROWSER_LOG_LEVEL
value: {{.Values.databrowser.loglevel}}
- name: DATABROWSER_PG_TABLE_2017
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because when I tried to deploy data-browser in hmda dev with a helm command I ran into errors related to missing mlartable tables in the configmap

value: intentionally_left_blank
- name: DATABROWSER_PG_TABLE_2018
valueFrom:
configMapKeyRef:
name: pgtables-configmap
key: mlartable.2018
- name: DATABROWSER_PG_TABLE_2019
valueFrom:
configMapKeyRef:
name: pgtables-configmap
key: mlartable.2019
- name: DATABROWSER_PG_TABLE_2020
valueFrom:
configMapKeyRef:
name: pgtables-configmap
key: mlartable.2020
- name: DATABROWSER_PG_TABLE_2021
valueFrom:
configMapKeyRef:
name: pgtables-configmap
key: mlartable.2021
- name: DATABROWSER_PG_TABLE_2022
valueFrom:
configMapKeyRef:
name: pgtables-configmap
key: mlartable.2022
- name: DATABROWSER_PG_TABLE_2023
valueFrom:
configMapKeyRef:
name: pgtables-configmap
key: mlartable.2023
- name: REDIS_HOSTNAME
value: {{.Values.databrowser.redis}}
- name: REDIS_PROTOCOL
10 changes: 0 additions & 10 deletions kubernetes/ratespread-calculator/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -50,16 +50,6 @@ spec:
secretKeyRef:
name: aws-credentials
key: aws-secret-access-key
- name: AWS_ACCESS_KEY_ID
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because when deploying ratespread-calculator, helm gave warnings about duplicate names for "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY". Updating this fixed those warnings.

valueFrom:
secretKeyRef:
name: aws-credentials
key: aws-access-key-id
- name: AWS_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: aws-credentials
key: aws-secret-access-key
- name: APOR_SCHEDULE
valueFrom:
configMapKeyRef: