Migrate to RTK Query #553
Merged
Migrate to RTK Query #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flacoman91
force-pushed
the
DATAP-1576-rtk-query-upgrade
branch
5 times, most recently
from
d2f14cc to
5b4e295
Compare
flacoman91
force-pushed
the
DATAP-1576-rtk-query-upgrade
branch
6 times, most recently
from
a5f3ee1 to
8e06b0f
Compare
flacoman91
force-pushed
the
DATAP-1576-rtk-query-upgrade
branch
4 times, most recently
from
f9ebdd3 to
cd3d768
Compare
cdmh219
reviewed
Nov 22, 2024
src/components/Filters/Aggregation/AggregationItem/AggregationItem.spec.js
Show resolved
Hide resolved
src/components/Trends/TrendDepthToggle/TrendDepthToggle.spec.js
Outdated
Show resolved
Hide resolved
src/components/Trends/TrendDepthToggle/TrendDepthToggle.spec.js
Outdated
Show resolved
Hide resolved
|
In addition to the feedback provided in each file, please also make sure to update the Cypress tests accordingly (if needed). When I tried running |
test update, restore detail slice temporary to test something remove detail slice working aggregations query standardize fetch aggs into single hook remove aggsslice remove queryManager middleware cleanup, remove more stuff working map tab logic to disable query hook remove message middleware list view working cleanup, passing query params to api so we can extract to transformResponse Save work save work move color map to api remove query manager things missing dep more loogic to prevent query from firing when not initialized working pagination, moved breakpoints to API, and passing them through pagination component remove breakpoints from querySlice cleanup remove persist clean up comments and errors complaint detail test updates save work, clearing out URL unused clode cleanup querySlice tests updated trends test fixes tile map test squash lines add prettier ignore file updating tests, refactor product save. working tests for Company filter refactor update dist fixing pill test issue test fix restructure files restore update tests save some work trend depth toggle unit test squash moved files focus header test fixes? save stuff searchpanel fix fixing pagination unit tests fixing app.spec test unit test actionbar aggregation item test condense aggregation item test aggregation item test trends panel tests print info tests move file unit test :( working map panel test simple filter fix data export unit test row test tour test line chart test unit test fixes delete detail test for redux store update unit tests test coverage update tests, fix condition causing url to not synch properly when copy/pasting url fix cypress tests fix url req call move api hooks to folder update dist update dist
flacoman91
force-pushed
the
DATAP-1576-rtk-query-upgrade
branch
from
cfc89ca to
ea8a216
Compare
The tests were updated since some API calls changed. I wasn't seeing this. I can look into it further if you can provide a screenshot. The cypress tests are also running in CI. |
…76-rtk-query-upgrade # Conflicts: # dist/ccdb5.css.map # dist/ccdb5.js # dist/ccdb5.js.map
update tests fixing up tests for complaints api, update fixtures linting
flacoman91
force-pushed
the
DATAP-1576-rtk-query-upgrade
branch
from
2ec104e to
a19b430
Compare
cdmh219
approved these changes
Dec 13, 2024
cdmh219
requested changes
Dec 13, 2024
cdmh219
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the app to use RTK Query