Skip to content

Commit

Permalink
Fixing EC2 + MySQL example (#63)
Browse files Browse the repository at this point in the history
* Fixing EC2 + MySQL example

* Fixing Postgres module

* Fix

* Final fix

* Fixing RDS Postgres test

* Fix
  • Loading branch information
andreaswittig authored Dec 19, 2024
1 parent 6cb3c28 commit 46e4d5d
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 9 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
with:
role-to-assume: 'arn:aws:iam::068189904525:role/github-openid-connect'
aws-region: 'eu-west-1'
role-duration-seconds: 7200
- uses: actions/setup-node@v4
with:
node-version: '18.x'
Expand Down
1 change: 1 addition & 0 deletions examples/ec2-mysql/example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ Resources:
VpcModule: !GetAtt 'Vpc.Outputs.StackName'
ClientSgModule: !GetAtt 'ClientSg.Outputs.StackName'
AlertingModule: !GetAtt 'Alerting.Outputs.StackName'
EngineVersion: '8.4.3'
DBMasterUserPassword: insecure
DBBackupRetentionPeriod: '0' # speed up the example (do not set to 0 in production!)
DBMultiAZ: 'false' # speed up the example (do not set to false in production!)
Expand Down
2 changes: 1 addition & 1 deletion examples/ec2-postgres/example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Resources:
DBMasterUserPassword: insecure
DBBackupRetentionPeriod: '0' # speed up the example (do not set to 0 in production!)
DBMultiAZ: 'false' # speed up the example (do not set to false in production!)
EngineVersion: '14.2'
EngineVersion: '17.2'
TemplateURL: './node_modules/@cfn-modules/rds-postgres/module.yml'
Instance:
Type: 'AWS::CloudFormation::Stack'
Expand Down
26 changes: 19 additions & 7 deletions examples/ec2-postgres/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/ec2-postgres/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"dependencies": {
"@cfn-modules/alerting": "1.2.2",
"@cfn-modules/vpc": "2.3.0",
"@cfn-modules/rds-postgres": "2.3.1",
"@cfn-modules/rds-postgres": "2.4.6",
"@cfn-modules/client-sg": "1.0.0",
"@cfn-modules/ec2-instance-amazon-linux": "2.4.0"
}
Expand Down

0 comments on commit 46e4d5d

Please sign in to comment.