Run aabb in wasm
#850
Draft
Run aabb in wasm
#850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just removing the assertion in aabb.typ already saved 30%. Apart from that, switching to WebAssembly has no effect except that it found a bug where floats and integers were put together in an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 30% faster. Plotting 1000 circles now takes less than 1 s on my system 🚀 (down from 1.6 s).
This is mostly due to removing this line though:
This check is now still done inside wasm. If the
ptis not an array the program will error when trying to parse the incoming cbor data.Also, Rust found a small bug, if you can call it that. Usually a
ptis aVec<f64>, but sometimes inside CeTZ a0(integer) was introduced instead of a float.This PR depends on #848. I'll leave this one on draft until the other PR is merged.