Backport improved line clipping #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
backport-rect-clipping
branch
from
debc37f
to
bb288c0
Compare
johannes-wolf
force-pushed
the
backport-rect-clipping
branch
from
bb288c0
to
2706a4c
Compare
|
This looks good to me, is there any risk that merging this would mess up merging refactor into main or would git take care of that? |
|
I've created a separate branch based on current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I do not think we get the refactoring ready soon, I propose to
port changes to master.
Maybe we can even port the new API (e.g.
plot.add.xy, ...) over to the current state.I think we should pick refactorings from the refactor branch step by step instead of doing everything at once, that way we can ship something working – which I would really like to do soon.