Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar plot through scientific-polar axis style #26

Closed
wants to merge 10 commits into from

Conversation

jamesrswift
Copy link
Collaborator

@jamesrswift jamesrswift commented Jul 30, 2024

Draft PR on the implementation of a plot that accepts polar coordinates. Achieved by drawing the axes, ticks, and grid manually, aswell as a custom transform.

image

It may be work rethinking how plots are created, as there's a good degree of refactorization that's possible here, something which will be even more true when other plot types are implemented (ternary diagrams, etc). Currently, the axis-style is truly independent from transformations, and its a bit hacky to get them to work together currently. A better way of doing it may be to give full control from the data viewport over to axes presets (which should probably then be renamed).

It would then make it trivial to implement plots that rely on weird transformations.

To do:

  • Put the ticks on the angular axis
  • Allow the phase of the angular axis to be adjusted
  • Support logarithm transformations on radius? Not sure if thats possible
  • Consider a better way of rendering the radial axis

@jamesrswift
Copy link
Collaborator Author

Current state:

image

@jamesrswift jamesrswift marked this pull request as ready for review July 31, 2024 10:15
@jamesrswift jamesrswift marked this pull request as draft July 31, 2024 16:06
@jamesrswift
Copy link
Collaborator Author

Converted to draft as this can be implemented more simply if a more aggressive refactor is undertaken first (in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant