Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example dataset to new projects #181

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MichaelTamaki
Copy link

No description provided.

@pep8speaks
Copy link

pep8speaks commented Apr 6, 2017

Hello @MichaelTamaki! Thanks for updating the PR.

Line 60:1: W293 blank line contains whitespace
Line 64:1: W293 blank line contains whitespace

Comment last updated on May 01, 2017 at 23:10 Hours UTC

@acrellin
Copy link
Member

acrellin commented Apr 6, 2017

What's the motivation for this?

@MichaelTamaki
Copy link
Author

@acrellin This main purpose for this is to provide an example dataset for the click through tutorial to use.

'tests', 'data', 'asas_training_subset_classes.dat')
tarball = pjoin(os.path.dirname(__file__),
'tests', 'data', 'asas_training_subset.tar.gz')
header = shutil.copy2(header, cfg['paths']['upload_folder'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only copy if not already in place: http://stackoverflow.com/a/82852/214686

@stefanv
Copy link
Contributor

stefanv commented Apr 6, 2017

Please add a test to ensure that the test data is in place.

@MichaelTamaki
Copy link
Author

Reset branch to remove unnecessary commits

@MichaelTamaki
Copy link
Author

Re-opening to show progress to @stefanv. After pressing the button I added, message_proxy crashes and I get 2 errors:
Uncaught TypeError: dispatch is not a function
Failed to load resource: the server responded with a status of 405 (Method Not Allowed)

@MichaelTamaki
Copy link
Author

Button now has functionality, just needs tests and style

@bnaul bnaul force-pushed the master branch 4 times, most recently from afacff9 to 1640cac Compare October 27, 2017 19:32
@acrellin
Copy link
Member

@stefanv what's the status of this?

@stefanv
Copy link
Contributor

stefanv commented May 14, 2018

I think this functionality would still be great to have; but the code has changed quite a bit, so we'll probably have to restructure some of it at least.

@acrellin acrellin force-pushed the master branch 4 times, most recently from 36a6dcc to e4eb913 Compare December 9, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants