Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter expert: Docs fix, treat false as false for filter_regex and add logging #2499

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

sebix
Copy link
Member

@sebix sebix commented May 10, 2024

  • Docs: fix syntax in filter expert bot documentation
  • filter expert: treat filter_regex false as False
    if the parameter
    filter_regex: false
    was set, the bot treated this as true
    with this patch, false is treated as false
  • filter expert: add debugging output for comparisons
    if users or devs run the bot in DEBUG log level, there was no useful
    output yet.
    This change adds two log statements, showing which comparision was made

@sebix sebix added this to the 3.3.1 milestone May 10, 2024
@@ -64,7 +64,7 @@ def init(self):
self.filter = False

self.regex = False
if self.filter_regex is not None:
if self.filter_regex is not None and self.filter_regex is not False:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this attribute is empty or evaluates to false

In such case, the if not self.filter_regex would be better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, right, that should cover more cases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, no. this now triggers 10 test fails

@sebix sebix force-pushed the filter-docs branch 2 times, most recently from 832534e to fdd209b Compare July 9, 2024 06:45
sebix added 2 commits July 9, 2024 08:46
if the parameter
filter_regex: false
was set, the bot treated this as true
with this patch, false is treated as false
if users or devs run the bot in DEBUG log level, there was no useful
output yet.
This change adds two log statements, showing which comparision was made
@sebix sebix merged commit a8b2a64 into develop Jul 9, 2024
31 checks passed
@sebix sebix deleted the filter-docs branch July 9, 2024 06:57
@sebix sebix restored the filter-docs branch July 9, 2024 06:58
@sebix sebix deleted the filter-docs branch July 9, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants