Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bots/collectors/api: make socket file permissions configurable #2417

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

monoidic
Copy link
Contributor

@monoidic monoidic commented Oct 20, 2023

By default, tornado.netutil.bind_unix_socket creates socket files with 600 permissions and which have the owner and group of the creating user (intelmq). This does not work well in the common case of the process at the other end of the socket not being a process running as the intelmq user.
This commit adds socket_perms and socket_group configuration parameters to the bot to allow for the file's permissions to be changed.

Copy link
Contributor

@kamil-certat kamil-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change! The code looks good. Could you please update the changelog (CHANGELOG.md) and possibly also the Bot's documentation in docs/bots.rst?

@sebix
Copy link
Member

sebix commented Oct 25, 2023

Good change, as @kamil-certat said. With docs, it would be good to merge.

@sebix sebix added component: bots feature Indicates new feature requests or new features labels Oct 25, 2023
@monoidic
Copy link
Contributor Author

Done. Apologies for the delay

@kamil-certat
Copy link
Contributor

@monoidic In the meantime, we have changed the documentation system. May you merge develop and move your docs changes to the docs/user/bots.md?

@sebix
Copy link
Member

sebix commented Nov 21, 2023

I fixed the merge errors (some unrelated changes were part of the PR's commits), now ready for merge after the CI checks pass.

@sebix
Copy link
Member

sebix commented Nov 21, 2023

Merging, as reviewed OK by @kamil-certat

@sebix sebix merged commit 95e4fec into certtools:develop Nov 21, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants