Discover bots based on the entry points #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bot discovery algorithm was rewritten to use entry point names instead of the file structure. This allow really easy developing of packages with custom bots. Not that the 'group' feature of entry points wasn't used because we require bots to register callable scripts that are later used to start bot's processes.
sebix
added
feature
sebix
requested changes
Sep 26, 2023
contrib/example-extension-package/mybots/bots/collectors/custom/collector.py
Show resolved
Hide resolved
contrib/example-extension-package/mybots/bots/collectors/custom/collector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian <[email protected]>
5 tasks
sebix
requested changes
Sep 27, 2023
|
After testing in our environment - fixes to places, where bot modules are imported |
sebix
approved these changes
Oct 16, 2023
|
For further tests on more platforms I pushed your branch (with #2416) to the "unstable" package repo: https://build.opensuse.org/package/show/home:sebix:intelmq:unstable/intelmq |
sebix
reviewed
Oct 16, 2023
|
Thanks for the unstable package - I'll try to test the integration with the DEB package in the next two weeks. If you had your own use cases for tests, it would be great if you also could do some tests. From my side - the change is now used and works great for in our systems. |
|
@sebix I have just tested the integration with DEB package (IntelMQ from deb, additional bots from pip) - it works well! As it also works good in our instances for w few weeks already, I think we can merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bot discovery algorithm was rewritten to use entry point
names instead of the file structure. This allow really easy
developing of packages with custom bots.
Note that the 'group' feature of entry points wasn't used
because we require bots to register callable scripts that
are later used to start bot's processes.