Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parameter for outputfile in initdb script #2385

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Added parameter for outputfile in initdb script #2385

merged 5 commits into from
Jul 14, 2023

Conversation

sebkuf
Copy link
Contributor

@sebkuf sebkuf commented Jul 13, 2023

Now you can define where to save the outputfile of the intelmq_psql_initdb script.

kamil-certat
kamil-certat reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@kamil-certat kamil-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to leave default generated help messages – then noone needs to manually adjust them when adding new command or changing filename.

intelmq/bin/intelmq_psql_initdb.py Outdated Show resolved Hide resolved
intelmq/bin/intelmq_psql_initdb.py Outdated Show resolved Hide resolved
@sebkuf
Removed hardcoded scriptname and usage
7d7d13c 
Removed the hardcoded scriptname and usage in the help menu
@sebix sebix merged commit c76bf67 into certtools:develop Jul 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-certat kamil-certat kamil-certat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebkuf @kamil-certat @sebix