Migrate to use Makefile modules #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
inteon
force-pushed
the
use_makefile_modules
branch
from
40b318b to
98e802f
Compare
|
/ok-to-test e2e tests should pass before we merge, naturally! |
The problem is that the e2e tests on master are used. |
|
I don't think we need to remove |
|
/ok-to-test |
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
use_makefile_modules
branch
from
97a9791 to
7f8bc44
Compare
|
It looks like it is very hard to get the e2e test to work in GH actions unless we change the action from "pull_request_target" to "pull_request". This makes it more difficult to test outside contributions, but I think the best solution is to move the repo to cert-manager org and move to prow for testing. |
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
use_makefile_modules
branch
from
7f8bc44 to
275fc67
Compare
|
closing in favor of #120 (which is merging from a branch instead of a fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see cert-manager/makefile-modules#3
Should prevent issues like #113 in the future.
Also, this will allow us to release Helm charts much easier.