Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 01 mse2023 feeback #5

Open
wants to merge 1 commit into
base: mse-305_2023
Choose a base branch
from

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Feb 27, 2023

lab-cosmo/chemiscope#269 (comment) in this PR

  • adapt error message of ex 3 saying wrong unit cell
  • improving in-notebook formatting for pbc-1.png and pbc-2.png

Open bugs

  • error messages in widget code input are not correctly shown to student, I think this is because widget code input fixed this in version 3.5.0, but we are using 3.0.0 because it the new version caused bugs, and in scicode-wigdets we removed it already. So I think we should temporary put it back here. Would fix this in a different PR
  • unit cell is not shown in chemiscope for some people on noto, chemiscope version is the same (0.5.1) and ase (3.22.1), pbc is True, cell is the same, discussed in Missing unit cell option in chemiscope jupyterwidget viewer lab-cosmo/chemiscope#269 (comment)

* adapt error message of ex 3 saying wrong unit cell

* improving in-notebook formatting for pbc-1.png and pbc-2.png
@agoscinski agoscinski changed the title Fixes for bugs from first lesson using notebook 01 Notebook 01 mse2023 feeback Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant