Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint/adapt to xclim>=0.45 #284

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Maint/adapt to xclim>=0.45 #284

merged 5 commits into from
Dec 6, 2023

Conversation

bzah
Copy link
Member

@bzah bzah commented Dec 6, 2023

Pull Request to resolve #281

  • Unit tests cover the changes.
  • These changes were tested on real data.
  • The relevant documentation has been added or updated.
  • A short description of the changes has been added to doc/source/references/release_notes.rst.

Describe the changes you made

  • Adapt generic indicators "excess" (gd4) and "deficit" HD17 to xclim 0.47
  • Increase minimal required version of xclim to 0.45 where breaking changes occured and bound it to 0.47 which is the latest.

Abel Aoun added 5 commits December 6, 2023 15:24
We can only guarantee that the latest version of icclim works with
 xclim >=0.45 and xclim <= 0.47.
If there is no breaking change in xclim 0.48, we will only need to
update the right bound.
Copy link

github-actions bot commented Dec 6, 2023

Coverage

Report
FileStmtsMissCoverMissing
icclim
   icclim_exceptions.py7186%20
   icclim_logger.py852966%24, 43, 65, 70–95, 105, 111–142, 150–155
   main.py2782691%120, 129, 405, 490, 516–517, 519–520, 522, 524–525, 527–528, 547–554, 622–627, 708, 715, 719
   utils.py37586%22, 33–34, 36–37
icclim/ecad
   xclim_binding.py48688%39, 43, 68, 72, 97, 101
icclim/generic_indices
   generic_indicators.py4868583%57, 60, 77, 81, 85, 98, 104, 178, 218, 225, 359, 388, 682, 713, 719, 727, 747, 910, 915, 935–941, 945, 975, 977, 1042–1043, 1076–1103, 1130–1151, 1167, 1176–1177, 1203–1233, 1239–1243, 1267
   standard_variable.py48198%19
   threshold.py4022195%199, 219, 223, 271, 287–290, 305, 312, 388, 529, 598, 699, 902, 924, 930, 1004, 1007, 1106–1108
icclim/models
   cf_calendar.py35197%20
   climate_variable.py1001090%103, 162, 173, 207, 213, 251, 255, 283–284, 321
   frequency.py1761194%167–170, 314–316, 323, 401, 427, 432
   index_group.py34197%33
   operator.py29197%14
   standard_index.py28389%56, 59, 63
icclim/pre_processing
   input_parsing.py1953781%74, 78–79, 84, 103, 167, 172, 178, 187, 200, 229, 245, 259, 279, 287, 289, 298, 307, 325, 339–347, 356–373, 395
   rechunk.py86298%38, 132
TOTAL257324091% 

Test results

Tests Skipped Failures Errors Time
189 0 💤 0 ❌ 0 🔥 1m 33s ⏱️

@bzah bzah merged commit b8ab259 into master Dec 6, 2023
5 checks passed
@bzah bzah deleted the maint/adapt_to_xclim_047 branch December 28, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with xclim 0.44 and 0.45 ?
1 participant