Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rxxp tot total computation #283

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

bzah
Copy link
Member

@bzah bzah commented Dec 6, 2023

Pull Request to resolve #256

  • Unit tests cover the changes.
  • These changes were tested on real data.
  • The relevant documentation has been added or updated.
  • A short description of the changes has been added to doc/source/references/release_notes.rst.

Describe the changes you made

When computing the total part of the rxxpTOT equation, we now properly convert the unit of the threshold min value before computing the total.

The unit of the thresolf min value is now converted before computation.
@bzah bzah force-pushed the fix/rxxpTOT_total_computation branch from 3777c41 to b4f050f Compare December 6, 2023 12:33
Copy link

github-actions bot commented Dec 6, 2023

Coverage

Report
FileStmtsMissCoverMissing
icclim
   icclim_exceptions.py7186%20
   icclim_logger.py852966%24, 43, 65, 70–95, 105, 111–142, 150–155
   main.py2782691%120, 129, 405, 490, 516–517, 519–520, 522, 524–525, 527–528, 547–554, 622–627, 708, 715, 719
   utils.py37586%22, 33–34, 36–37
icclim/ecad
   xclim_binding.py48688%39, 43, 68, 72, 97, 101
icclim/generic_indices
   generic_indicators.py4848582%57, 60, 77, 81, 85, 98, 104, 178, 218, 225, 359, 388, 680, 711, 717, 725, 745, 908, 913, 933–939, 943, 973, 975, 1040–1041, 1074–1101, 1128–1149, 1165, 1174–1175, 1201–1231, 1237–1241, 1265
   standard_variable.py48198%19
   threshold.py4022195%199, 219, 223, 271, 287–290, 305, 312, 388, 529, 598, 699, 902, 924, 930, 1004, 1007, 1106–1108
icclim/models
   cf_calendar.py35197%20
   climate_variable.py1001090%103, 162, 173, 207, 213, 251, 255, 283–284, 321
   frequency.py1761194%167–170, 314–316, 323, 401, 427, 432
   index_group.py34197%33
   operator.py29197%14
   standard_index.py28389%56, 59, 63
icclim/pre_processing
   input_parsing.py1953781%74, 78–79, 84, 103, 167, 172, 178, 187, 200, 229, 245, 259, 279, 287, 289, 298, 307, 325, 339–347, 356–373, 395
   rechunk.py86298%38, 132
TOTAL257124091% 

Test results

Tests Skipped Failures Errors Time
189 0 💤 0 ❌ 0 🔥 1m 45s ⏱️

@bzah bzah merged commit dc88a5a into master Dec 6, 2023
5 checks passed
@bzah bzah deleted the fix/rxxpTOT_total_computation branch December 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Problem with kg m-2 s-1 units for FractionOfTotal indicators
1 participant