Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/convert mm to mmday when possible #232

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

bzah
Copy link
Member

@bzah bzah commented Oct 20, 2022

Pull Request to resolve #xxx

  • Unit tests cover the changes.
  • These changes were tested on real data.
  • The relevant documentation has been added or updated.
  • A short description of the changes has been added to doc/source/references/release_notes.rst.

Describe the changes you made

  • Bump icc version to 6.0.0 for upcoming release
  • Remove ddNorth as it will be fixed by Enh/ecad wind indices #230
  • Convert input data that are recognized as a precipitation amount into precipitation rate
    This is done by using the standard_name and the units attribute of the input dataset.

Related work on xclim: Ouranosinc/xclim#1206

bzah and others added 5 commits October 20, 2022 18:18
It will be fixed and re-added by a dedicated wind indices PR.
This is meant to fix the issue we have with e-obs dataset where
the precipitation is not a flux but rather a "thickness_of_rainfall_amount".
Now, it will be automatically converted to a rate using xclim amount2rate function.
Note that if the dataset is discontinuous, amount2rate might convert,
amounts to a wrong rate[0].

[0] Ouranosinc/xclim#1206 (comment)
@github-actions
Copy link

github-actions bot commented Oct 20, 2022

Coverage

Report
FileStmtsMissCoverMissing
icclim
   icclim_exceptions.py7186%20
   icclim_logger.py852966%24, 43, 65, 70–95, 105, 111–142, 150–155
   main.py2692093%118, 127, 402, 487, 513–514, 516–517, 519, 521–522, 524–525, 544–551, 688, 695, 699
   utils.py29197%20
icclim/generic_indices
   cf_var_metadata.py46198%19
   generic_indicators.py4678482%57, 60, 77, 81, 85, 98, 104, 178, 217, 224, 348, 377, 659, 690, 696, 704, 723, 801, 821–827, 831, 861, 863, 928–929, 962–989, 1016–1037, 1053, 1062–1063, 1069–1099, 1105–1109, 1133
icclim/models
   cf_calendar.py35197%20
   climate_variable.py961090%97, 141, 152, 186, 192, 230, 234, 262–263, 300
   frequency.py1761194%167–170, 314–316, 323, 401, 427, 432
   index_group.py34197%33
   operator.py29197%14
   registry.py33197%26
   standard_index.py30293%65, 69
   threshold.py3892693%198, 225, 229, 277, 298, 305, 318–324, 329–340, 381, 386, 517, 586, 680, 883, 905, 911, 985, 988, 1086–1088
icclim/pre_processing
   input_parsing.py1783381%41, 105, 110, 116, 125, 138, 167, 183, 197, 217, 225, 227, 236, 245, 263, 277–285, 294–309, 331
   rechunk.py86298%38, 132
TOTAL238222491% 

Test results

Tests Skipped Failures Errors Time
181 0 💤 0 ❌ 0 🔥 2m 5s ⏱️

@bzah bzah merged commit 471f1b3 into master Oct 20, 2022
@bzah bzah deleted the enh/convert_mm_to_mmday_when_possible branch October 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant