Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0_11 dev #1411

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
40b65d1
deps: Add MySQL to CI workflow (#1398)
bf4 Jan 25, 2023
7bd836f
fix: Reliably quote columns/tables (#1400)
bf4 Feb 2, 2023
a50cac5
Add docker testing setup (#1403)
lgebhardt Mar 3, 2023
5868a37
fix: test the adapter-specific query ordering (#1402)
bf4 Mar 10, 2023
92c5fe5
V0.11 refactor resource classes to modules (#1406)
lgebhardt Sep 19, 2023
9837c36
Add frozen_string_literal: true
lgebhardt Sep 19, 2023
1b8f05f
Restore missing requires
lgebhardt Sep 19, 2023
2dd0589
fix: warnings (#1401)
bf4 Sep 19, 2023
125cef4
Restore `use_related_resource_records_for_joins` for v0_10 (#1412)
lgebhardt Sep 26, 2023
f00cb05
Bump jsonapi-resources to 0.11.0.beta2
lgebhardt Sep 26, 2023
fdbf26e
fix: more reliable check of module is included (#1418)
bf4 Oct 27, 2023
ba643ac
Fix tests for V0.11 and Rails 7.1 (#1420)
lgebhardt Nov 1, 2023
c36af71
Namespace references to Rails using `::Rails` to avoid conflicts with…
lgebhardt Nov 16, 2023
0b642c7
chore: remove sorted_set dependency (#1423)
bf4 Jan 10, 2024
18e150c
Make SortedSet for identity arrays optional (#1427)
lgebhardt Jan 11, 2024
c61110f
Store the resource_klass and id in an array for efficiency (#1428)
lgebhardt Jan 13, 2024
52da65e
Rework ResourceIdentity <=> operator (#1430)
lgebhardt Jan 16, 2024
c052d46
V0 11 dev performance (#1431)
lgebhardt Jan 16, 2024
000e560
fix: allow multiple resource relation retrieval methods (#1425)
bf4 Jan 17, 2024
4d56ce4
refactor: separate polymorphic functions (#1433)
bf4 Jan 19, 2024
287e8dd
feat: teach JR in tests to parse the response (#1437)
bf4 Jan 22, 2024
b0137ba
chore: address deprecations (#1436)
bf4 Jan 22, 2024
cc65781
fix: format model polymorphic type from resource object type (#1435)
bf4 Jan 22, 2024
7fa3352
fix: railtie to use correct load hook (#1438)
bf4 Jan 24, 2024
f3bbf0c
fix: more flexible polymorphic types lookup (#1434)
bf4 Jan 25, 2024
1d5977b
Update the testing matrix (#1442)
lgebhardt Jan 26, 2024
7a1fd32
Polymorphic types override per relationship (#1440)
lgebhardt Jan 26, 2024
e55371a
Fix issue with relationship sorts due to missing join_manager (#1443)
lgebhardt Jan 26, 2024
fa3e059
fix: add railtie to clear cache after class changes (#1448)
adamkiczula Feb 8, 2024
3509c4a
Warn on missing inverse relationships (#1451)
lgebhardt Apr 17, 2024
05c10bd
Bring in pr/1450 to join_manager_v10.rb
lgebhardt Apr 18, 2024
9b9961d
Fix issue with extra `` in code
lgebhardt Jan 9, 2024
42a11b7
Change method used to retrieve rack status (#1457)
pareeohnos Nov 14, 2024
d3c094b
fix: validate type matches resource type for sparse fieldsets (#1461)
adamkiczula Nov 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix issue with extra `` in code
lgebhardt committed Apr 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9b9961d41e020fe21bf7f9e1c164ca2f68fe2f7d
2 changes: 1 addition & 1 deletion lib/jsonapi/active_relation_retrieval_v10.rb
Original file line number Diff line number Diff line change
@@ -465,7 +465,7 @@ def find_related_monomorphic_fragments(source_fragments, relationship, options,

if connect_source_identity
inverse_relationship = relationship._inverse_relationship
fragments[rid].add_related_identity(inverse_relationship.name, source_rid) if inverse_relationship``.present?
fragments[rid].add_related_identity(inverse_relationship.name, source_rid) if inverse_relationship.present?
end
end