-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose flag to determine whether a composite is indexed #196
Open
dbcfd
wants to merge
4
commits into
main
Choose a base branch
from
feat/reload-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,13 @@ export function getDirPath(path: PathInput): string { | |
/** | ||
* Create a Composite from a GraphQL schema path. | ||
*/ | ||
export async function createComposite(ceramic: CeramicClient, path: PathInput): Promise<Composite> { | ||
export async function createComposite( | ||
ceramic: CeramicClient, | ||
path: PathInput, | ||
deploy: boolean, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a breaking API change, please set a default value or bump to v0.7 with docs updates. |
||
): Promise<Composite> { | ||
const file = await readFile(getFilePath(path)) | ||
return await Composite.create({ ceramic, schema: file.toString() }) | ||
return await Composite.create({ ceramic, schema: file.toString(), index: deploy }) | ||
} | ||
|
||
/** | ||
|
@@ -36,12 +40,12 @@ export async function createComposite(ceramic: CeramicClient, path: PathInput): | |
export async function readEncodedComposite( | ||
ceramic: CeramicClient | string, | ||
path: PathInput, | ||
index?: boolean, | ||
deploy?: boolean, | ||
): Promise<Composite> { | ||
const client = typeof ceramic === 'string' ? new CeramicClient(ceramic) : ceramic | ||
const file = getFilePath(path) | ||
const definition = (await readJSON(file)) as EncodedCompositeDefinition | ||
return Composite.fromJSON({ ceramic: client, definition: definition, index: index }) | ||
return Composite.fromJSON({ ceramic: client, definition: definition, index: deploy }) | ||
} | ||
|
||
/** | ||
|
@@ -112,7 +116,7 @@ export async function writeEncodedCompositeRuntime( | |
runtimePath: PathInput, | ||
schemaPath?: PathInput, | ||
): Promise<void> { | ||
const definition = await readEncodedComposite(ceramic, definitionPath) | ||
const definition = await readEncodedComposite(ceramic, definitionPath, false) | ||
const runtime = definition.toRuntime() | ||
await writeRuntimeDefinition(runtime, runtimePath) | ||
if (schemaPath != null) { | ||
|
@@ -130,7 +134,7 @@ export async function mergeEncodedComposites( | |
): Promise<string> { | ||
const sources = Array.isArray(source) ? source : [source] | ||
const composites = await Promise.all( | ||
sources.map(async (path) => await readEncodedComposite(ceramic, path)), | ||
sources.map(async (path) => await readEncodedComposite(ceramic, path, false)), | ||
) | ||
const file = getFilePath(destination) | ||
await writeEncodedComposite(Composite.from(composites), file) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel super strongly about it, but I lean towards making create not deploy by default, so users have to explicitly deploy when they're ready. I think this will help with more complex situations where devs wants to create and merge multiple composites, possibly adding indices and views along the way, before finally deploying the final unified composite as the last step.
I could be swayed on this though if there's a case for why it's better to deploy by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what does
composite:from-model
do? That one seems even more like it definitely shouldn't auto-deploy since you're likely to want to add indices to it before deploying. And if that one doesn't auto-deploy, then I feel like this shouldn't either just for consistency sake if nothing elseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doing this just to maintain the existing behavior, so this change won't suddenly cause things to "stop working" for users that aren't calling deploy.
I'm not entirely sure which way is better either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I guess preserving existing behavior makes sense