Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(did-session): session removal support #187

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

oed
Copy link
Member

@oed oed commented Feb 12, 2024

Description

This PR adds support for removing sessions that have been created using DIDSession.get(...).

Additionally:

  • DIDSession.hasSessionFor(...) now returns false if the persisted session is expired
  • Added tests to make sure sessions are properly renewed if expired on call to DIDSession.get(...)

How Has This Been Tested?

Cleaned up the test suite for DIDSession package into categories and added new tests for persisted sessions.

@oed oed requested review from ukstv, stbrody and dbcfd February 12, 2024 18:56
@oed oed self-assigned this Feb 12, 2024
Copy link
Contributor

@ukstv ukstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

@oed oed merged commit e70a774 into main Feb 13, 2024
9 checks passed
@oed oed deleted the feat/delete-sessions branch February 13, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants