Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release for multiformats 13 #181

Closed
wants to merge 1 commit into from
Closed

Conversation

dbcfd
Copy link
Contributor

@dbcfd dbcfd commented Jan 3, 2024

No description provided.

@dbcfd dbcfd requested a review from dav1do January 3, 2024 19:31
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized these docs mention including every package name/version in the commit.. any chance you can amend it and re-push?

And it looks like some of the historical releases used the package.json file rather than the changeset file? Here is the list (hopefully I didn't miss any)

[email protected], [email protected], @didtools/[email protected], @didtools/[email protected], @didtools/[email protected], @didtools/[email protected], [email protected], [email protected], @didtools/[email protected], @didtools/[email protected], @didtools/[email protected], @didtools/[email protected], @didtools/[email protected]

looks like these four weren't updated: pkh-did-resolver, @didtools/pkh-ethereum, @didtools/pkh-stacks, @didtools/siwx

and I'm not sure if we even care to publish most of these, especially the unstable packages.

@dbcfd dbcfd force-pushed the release/major-multiformats branch from d7a3433 to c72542d Compare January 3, 2024 23:43
@dbcfd dbcfd requested a review from dav1do January 3, 2024 23:43
@dbcfd dbcfd closed this Jan 4, 2024
@dbcfd dbcfd deleted the release/major-multiformats branch January 4, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants