chore: rework build and integration tests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this might be a mistake for CI but the defaults have changed
…er and remove jest env overrides seems simple to just use beforeAll/afterAll to set up the client since we know what to expect. the withContainer package didn't allow multiple ports, so modified to do so so we can eventually use 1 image for multiple files if we want or use this for other purposes. in the end, didn't really need it since we only need api or flight, technically as it is, but it isn't super complex and lets us modify it as desired
…ly build this seems more predictable for CI/dev
dav1do
force-pushed
the
chore/rework-build
branch
from
002e370 to
373b2c9
Compare
avoid tooManyRequests pulling images simulteanously in CI
Merged
nathanielc
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a lot of changes as I was adding wasm for the flight-sql-client in #29 so I'm pulling out some of the unrelated changes. I reworked the build system quite a bit... open to reverting/changing things but I found some of the install/prepare hook build stuff a bit odd (and the cause of a lot of my grief when build wasn't building my code).
I plan to replace both of these workflows in #29, but splitting out some of these changes that are groundwork for the new package will hopefully make it easier to review.
withContainerspackage and made a local version to make it easier to specify multiple ports for ceramic one (flight sql and API) and generally have more control. I intended to run one image for everything since they can get rate limited, but haven't found a nice way to make that work. So we could probably get a way with 1 port specified per test file if we don't want our own, but it was a tiny package (1 file).