-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw/admin: support new-bucket-name for LinkBucket #1046
Open
sj14
wants to merge
1
commit into
ceph:master
Choose a base branch
from
sj14:sj/link-new-bucket-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sj14
force-pushed
the
sj/link-new-bucket-name
branch
7 times, most recently
from
November 28, 2024 13:40
f173e16
to
01c4a18
Compare
anoopcs9
reviewed
Nov 29, 2024
sj14
force-pushed
the
sj/link-new-bucket-name
branch
3 times, most recently
from
December 16, 2024 11:51
e9005b2
to
26f1b1d
Compare
anoopcs9
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
anoopcs9
added
the
API
This PR includes a change to the public API of a go-ceph package
label
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mergifyio rebase |
Signed-off-by: Simon Jürgensmeyer <[email protected]>
✅ Branch has been successfully rebased |
anoopcs9
force-pushed
the
sj/link-new-bucket-name
branch
from
December 17, 2024 08:29
26f1b1d
to
28ba7bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new-bucket-name
parameter toBucketLinkInput
which allows renaming a specific bucket.Checklist
//go:build ceph_preview
make api-update
to record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyio
rebase
to rebase your PR when github indicates that the PR is out of date with the base branch.