Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs: Adjust with the fallocate API changes #1045

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

anoopcs9
Copy link
Collaborator

Recent behavioural changes w.r.t fallocate API calls for corresponding changes in our tests which uses mode 0. In addition to skipping those existing tests we try to cover up the time taken for backports to land in released versions causing CI failures in our pre-release jobs. This has been implemented by creating a new test file intended to be controlled and maintained using required build tags. The new test file can be removed once all the expected backports are available with released versions.

fixes #1044

There has been an internal change with fallocate API[1] forcing us not
to run those fallocate tests which uses mode as 0. For now we skip those
tests on main branch.

[1] ceph/ceph#59725

Signed-off-by: Anoop C S <[email protected]>
There are backports created for fallocate API changes[1] that got merged
recently. Considering the time taken for these backports to get in to
release branches and finally as a released version we create a separate
test file to have more fine grained control over various pre-release CI
jobs with the help of corresponding build tags.

Modification of build tags should go hand-in-hand with the version
detection logic used in file_test.go once a backport is available in
released version.

[1] ceph/ceph#59725

Signed-off-by: Anoop C S <[email protected]>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me.

cephfs/file_test.go Show resolved Hide resolved
@phlogistonjohn
Copy link
Collaborator

I see that the PR is unlabeled so far. If you're OK with only my review feel fre to put the no-API label on.

@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Nov 12, 2024
@anoopcs9
Copy link
Collaborator Author

I see that the PR is unlabeled so far. If you're OK with only my review feel free to put the no-API label on.

Ah, I seem to forget that from time to time.
Done.

@mergify mergify bot merged commit ab45bcd into ceph:master Nov 12, 2024
16 checks passed
@anoopcs9 anoopcs9 deleted the fix-fallocate-mode-zero-tests branch November 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test failures on main for TestFallocate
2 participants