e2e: add tests for RBD VolumeGroupSnapshots #4899
Conversation
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
This job is expected to pass, with the VolumeGroupSnapshot test getting skipped. |
The e2e run contains this note in the logs: |
There was a problem hiding this comment.
@nixpanic we dont support running test with different version or the cephcsi driver in other words the e2e and the supported cephcsi version are tied, am not sure having this check helps because we have the required base image, this check becomes obsolute and not holds much value. should we make this changes as part of the PR which is actual testing the code changes?
|
@Madhu-1, once this and the VolumeGroupSnapshot PR are merged, we can create a PR that updates the base image to the Ceph main branch version that includes the required features. There is no Ceph release yet that includes them, so for the moment, we can run the tests on stable Ceph-CSI images. |
nixpanic
added
the
ci/skip/multi-arch-build
|
@Mergifyio rebase |
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
e2e/rbd/volume-group-snapshot
branch
from
c097524
to
d0e18fb
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
| return vgsc, nil | ||
| } | ||
|
|
||
| func (rvgs *rbdVolumeGroupSnapshot) ValidateResourcesForCreate(vgs *groupsnapapi.VolumeGroupSnapshot) error { |
There was a problem hiding this comment.
good to have comment for function description, maybe describe the validation criteria.
|
|
||
| var _ VolumeGroupSnapshotter = &rbdVolumeGroupSnapshot{} | ||
|
|
||
| func newRBDVolumeGroupSnapshot(f *framework.Framework, namespace, |
There was a problem hiding this comment.
This function creates volumegroupsnapshot but the function name is not self-explanatory, so I think it will be good to have a comment here.
Support for RBD VolumeGroupSnapshots is coming soon. However the implementation depends on changes in librbd, which are currently only available in the Ceph master branch.
Only when librbd in the Ceph-CSI container has support for the new function, the tests should te attempred
Related issues
This is no a 100% strict dependency, as current Ceph releases do not have the required functions yet. It is expected that #4502 gets merged before Ceph has a stable release (non master branch builds).
Sortof-depends-on: #4502
Example YAML files that are used by the test are posted as #4901.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)