deploy: Add skipForceFlatten for daemonset nodeplugin #4869
Conversation
Signed-off-by: muxuelan <[email protected]>
|
Hi @muxuelanKK, thanks for the PR! Could you update the title of your commit to something like A keyword like Currently the PR description does not contain anything useful. You can either use the template that is present now, or describe the need for the change in free form (it is good practice to include a description in the commit too). |
nixpanic
changed the title
| hardMaxCloneDepth: 8 | ||
| # Soft limit for maximum number of nested volume clones that are taken before | ||
| # a flatten occurs | ||
| softMaxCloneDepth: 4 | ||
| # Maximum number of snapshots allowed on rbd image without flattening | ||
| maxSnapshotsOnImage: 450 | ||
| # Minimum number of snapshots allowed on rbd image to trigger flattening | ||
| minSnapshotsOnImage: 250 |
There was a problem hiding this comment.
can we comment these out instead of having default here as well?
| hardMaxCloneDepth: 8 | ||
| # Soft limit for maximum number of nested volume clones that are taken before | ||
| # a flatten occurs | ||
| softMaxCloneDepth: 4 | ||
| # Maximum number of snapshots allowed on rbd image without flattening | ||
| maxSnapshotsOnImage: 450 | ||
| # Minimum number of snapshots allowed on rbd image to trigger flattening | ||
| minSnapshotsOnImage: 250 |
There was a problem hiding this comment.
These values can be set for both controller and nodeplugin, lets have it in a common place and use it in both controller and plugins
| - "--rbdhardmaxclonedepth={{ .Values.nodeplugin.hardMaxCloneDepth }}" | ||
| - "--rbdsoftmaxclonedepth={{ .Values.nodeplugin.softMaxCloneDepth }}" | ||
| - "--maxsnapshotsonimage={{ .Values.nodeplugin.maxSnapshotsOnImage }}" | ||
| - "--minsnapshotsonimage={{ .Values.nodeplugin.minSnapshotsOnImage }}" |
There was a problem hiding this comment.
can you please make similar changes to deployment as well?
Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)