ci: strip quay.io from mirrored ceph/ceph:v18 image #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI jobs pull the ceph/ceph:v18 image (without `quay.io`). If the mirroring includes the registry host, the image can not be found. Updates: ceph#4030 Signed-off-by: Niels de Vos <[email protected]>
riya-singhal31
approved these changes
Aug 3, 2023
karthik-us
approved these changes
Aug 3, 2023
Madhu-1
reviewed
Aug 4, 2023
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| # ceph-csi devel | |||
| docker.io/rook/ceph:v1.12.1 rook/ceph:v1.12.1 | |||
| quay.io/ceph/ceph:v18 quay.io/ceph/ceph:v18 | |||
| quay.io/ceph/ceph:v18 ceph/ceph:v18 | |||
There was a problem hiding this comment.
@nixpanic why this is only required for v18 not for any other versions?
There was a problem hiding this comment.
I think I manually pusehed the other tags without quay.io, so they work fine. Ideally everything is automated and no manual pushing is needed anymore (in the future).
Madhu-1
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI jobs pull the ceph/ceph:v18 image (without
quay.io). If the mirroring includes the registry host, the image can not be found.Updates: #4030
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)