journal: only destroy the connection if it is set

Prevent re-use of a destroyed connection by setting it to `nil`. This way it is also safe to call `Destroy()` multiple times without causing a panic. Signed-off-by: Niels de Vos <[email protected]>
ceph · Oct 14, 2024 · 15b14a2 · 15b14a2
1 parent e154eae
commit 15b14a2
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/journal/volumegroupjournal.go b/internal/journal/volumegroupjournal.go
@@ -143,7 +143,10 @@ func (vgc *VolumeGroupJournalConfig) Connect(
 
 // Destroy frees any resources and invalidates the journal connection.
 func (vgjc *volumeGroupJournalConnection) Destroy() {
-	vgjc.connection.Destroy()
+	if vgjc.connection != nil {
+		vgjc.connection.Destroy()
+		vgjc.connection = nil
+	}
 }
 
 // VolumeGroupData contains the GroupUUID and VolumeGroupAttributes for a