Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

branch squid #2174

Merged
merged 7 commits into from
Dec 8, 2023
Merged

branch squid #2174

merged 7 commits into from
Dec 8, 2023

Conversation

rzarzynski
Copy link
Contributor

Based on #2109.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.

@rzarzynski
Copy link
Contributor Author

CC: @ljflores, @BlaineEXE, @neha-ojha.

rzarzynski added a commit to rzarzynski/ceph that referenced this pull request Dec 5, 2023
@neha-ojha neha-ojha requested review from BlaineEXE and guits December 6, 2023 18:46
@@ -21,6 +21,7 @@ FLAVORS ?= \
pacific,centos,8 \
quincy,centos,8 \
reef,centos,8 \
squid,centos,8 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember when we branched reef I was told squid would be built on el9-based images, are we going to continue with el8 at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, so please let me loop @cbodley in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guits we're still planning to drop el8 for squid, it's just been a slog to actually get el9 container builds working. i'll cc you on a discussion in the #sepia slack where dmick identified some missing packages need by the container build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be fine to merge as is, with squid-on-el8, and later – when we're ready – switch squid to to el9?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely, this shouldn't block the pr

there are separate discussions about the fate of this ceph-container repo in #2171 and moving the container builds into the ceph repo with ceph/ceph#54575. hopefully that can happen for squid, but someone will need to take the initiative on that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks @cbodley for clarifying.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be fine to merge as is, with squid-on-el8, and later – when we're ready – switch squid to to el9?

sure, I don't see anything that would block this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind linking to that Slack thread here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never tried to link a thread before - hope this works? https://ceph-storage.slack.com/archives/C1HFJ4VTN/p1701386424620719

contrib/common.sh Outdated Show resolved Hide resolved
@guits
Copy link
Collaborator

guits commented Dec 8, 2023

we might want to update .github/workflows/rhcs.yml too

@guits guits merged commit 0396eef into ceph:main Dec 8, 2023
8 checks passed
vshankar pushed a commit to ceph/ceph-ci that referenced this pull request Dec 13, 2023
cbodley pushed a commit to cbodley/ceph that referenced this pull request Dec 13, 2023
@dmick
Copy link
Member

dmick commented Dec 15, 2023

since squid packages don't exist yet, merging this has broken the container build, which we need to work for releasing reef

@dmick
Copy link
Member

dmick commented Dec 15, 2023

#2179

@rzarzynski rzarzynski mentioned this pull request Dec 15, 2023
14 tasks
ljflores pushed a commit to ljflores/ceph that referenced this pull request Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants