-
Notifications
You must be signed in to change notification settings - Fork 523
Conversation
Signed-off-by: Radosław Zarzyński <[email protected]>
…ganesha version Signed-off-by: Radosław Zarzyński <[email protected]>
…release Signed-off-by: Radosław Zarzyński <[email protected]>
Signed-off-by: Radosław Zarzyński <[email protected]>
CC: @ljflores, @BlaineEXE, @neha-ojha. |
Per ceph/ceph-container#2174. Signed-off-by: Radosław Zarzyński <[email protected]>
@@ -21,6 +21,7 @@ FLAVORS ?= \ | |||
pacific,centos,8 \ | |||
quincy,centos,8 \ | |||
reef,centos,8 \ | |||
squid,centos,8 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember when we branched reef I was told squid would be built on el9-based images, are we going to continue with el8 at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, so please let me loop @cbodley in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guits we're still planning to drop el8 for squid, it's just been a slog to actually get el9 container builds working. i'll cc you on a discussion in the #sepia slack where dmick identified some missing packages need by the container build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be fine to merge as is, with squid-on-el8, and later – when we're ready – switch squid to to el9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely, this shouldn't block the pr
there are separate discussions about the fate of this ceph-container repo in #2171 and moving the container builds into the ceph repo with ceph/ceph#54575. hopefully that can happen for squid, but someone will need to take the initiative on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks @cbodley for clarifying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be fine to merge as is, with squid-on-el8, and later – when we're ready – switch squid to to el9?
sure, I don't see anything that would block this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind linking to that Slack thread here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never tried to link a thread before - hope this works? https://ceph-storage.slack.com/archives/C1HFJ4VTN/p1701386424620719
we might want to update |
Signed-off-by: Radosław Zarzyński <[email protected]>
Signed-off-by: Radosław Zarzyński <[email protected]>
Signed-off-by: Radosław Zarzyński <[email protected]>
Per ceph/ceph-container#2174. Signed-off-by: Radosław Zarzyński <[email protected]>
Per ceph/ceph-container#2174. Signed-off-by: Radosław Zarzyński <[email protected]>
since squid packages don't exist yet, merging this has broken the container build, which we need to work for releasing reef |
Per ceph/ceph-container#2174. Signed-off-by: Radosław Zarzyński <[email protected]>
Based on #2109.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist: