Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Readme and ceph-disk activate if statement #115

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

akadoya
Copy link

@akadoya akadoya commented Aug 31, 2017

  1. Readme says 'device' is the key for OSD data device but codes are actually using 'data'.
  2. bash testing operator should be executed inside of bash resource rather than execute. (otherwise, this test case fails with [[ not found in some platforms)
  3. is_device is misleading name but it actually checks if it's a partition as mentioned in the comments. so ceph-disk activate should be executed with #{partitions} when is_device is empty = it's not including a partition number.
    Also added 2 lines to make debugging easier from chef client log.

@akadoya
Copy link
Author

akadoya commented Nov 1, 2017

Any update on this? I am adding some changes so this cookbook works in the real life in my fork. I'd love to contribute to this upstream, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants