Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archiving ceph directory for the job 'ceph-pr-clang-tidy' #2276

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Suyashd999
Copy link

The job ceph-pr-clang-tidy requires Ceph's build but since the job ceph-pull-requests is already building Ceph it is best to archive & copy the directory and work further upon it. It is done to save time and resources required to again build Ceph.

artifact required by: #2269

The job `ceph-pr-clang-tidy` requires Ceph's build but since the job `ceph-pull-requests` is already building Ceph it is best to archive & copy the directory and work further upon it. It is done to save time and resources required to again build Ceph.

Signed-off-by: Suyash Dongre <[email protected]>
@ceph-jenkins
Copy link

Can one of the admins verify this patch?

@dmick
Copy link
Member

dmick commented Aug 28, 2024

  1. I think there's also some sort of permissions that need to be granted to the tidy job by the make check job to allow it to use the artifacts (see for example ceph-setup and job.properties.copyartifact) 2) how long does ceph-tidy take? Do we want it to run on every ceph make-check build?

@Suyashd999
Copy link
Author

@dmick

  1. I think there's also some sort of permissions that need to be granted to the tidy job by the make check job to allow it to use the artifacts (see for example ceph-setup and job.properties.copyartifact)
  1. Yes we must allow Permission to Copy Artifact, I'll check it in the file mentioned by you.
  1. how long does ceph-tidy take?
  1. The clang-tidy would take a maximum of 15-20 minutes to complete execution.

Do we want it to run on every ceph make-check build?

Yes we must run after every make-check build.

@dmick
Copy link
Member

dmick commented Aug 28, 2024

Well, not "must", it, like everything, is a choice. Let me bring this up to the clt.

@Suyashd999
Copy link
Author

Well, not "must", it, like everything, is a choice. Let me bring this up to the clt.

Okay no problem

Added permission to copy the archived `.tar` file from `ceph-pull-requests` to `ceph-pr-clang-tidy`

Signed-off-by: Suyash Dongre <[email protected]>
@Suyashd999
Copy link
Author

think there's also some sort of permissions that need to be granted to the tidy job by the make check job to allow it to use the artifacts (see for example ceph-setup and job.properties.copyartifact)

Hi @dmick! I have added the code to give permission to our job ceph-pr-clang-tidy to copy artifacts from ceph-pull-requests
Please do check.

@Suyashd999
Copy link
Author

Well, not "must", it, like everything, is a choice. Let me bring this up to the clt.

@dmick
any update from clt?

@Suyashd999
Copy link
Author

does everything look good ? @dmick

@dmick
Copy link
Member

dmick commented Sep 5, 2024

I'm sorry we haven't made more progress with this. You've hit on an area of Ceph development that is not very flexible to new work right now. We're going to continue trying to move the discussion along.

@Suyashd999
Copy link
Author

Suyashd999 commented Sep 5, 2024

I'm sorry we haven't made more progress with this. You've hit on an area of Ceph development that is not very flexible to new work right now. We're going to continue trying to move the discussion along.

@dmick
I see.. Please let me know what should I do from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants