lp-gateway-queue: Ensure messages are processed in order #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wischli
reviewed
Sep 23, 2024
lemunozm
reviewed
Sep 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/gateway-message-processing #1992 +/- ##
===============================================================
Coverage 48.36% 48.37%
===============================================================
Files 183 183
Lines 13398 13412 +14
===============================================================
+ Hits 6480 6488 +8
- Misses 6918 6924 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cdamian
force-pushed
the
fix/lp-gateway-queue-ordered-processing
branch
from
d173b9c to
571bd9e
Compare
cdamian
commented
Oct 6, 2024
| .last() | ||
| .expect("Queue triggered evm tx.") | ||
| .clone(); | ||
|
|
||
| // The sender is the sender account on the gateway | ||
| assert_eq!(T::Sender::get().h160(), status.from); | ||
| assert_eq!(status.to.unwrap().0, to.0); | ||
| assert!(!receipt_ok(receipt)); |
There was a problem hiding this comment.
Note - given that the message processor implementation of the LP gateway is transactional, this check is no longer required.
lemunozm
approved these changes
Oct 7, 2024
Comment on lines
+241
to
+246
| LastProcessedNonce::<T>::set(last_processed_nonce); | ||
|
|
||
| // 1 write for setting the last processed nonce | ||
| weight_used.saturating_accrue(T::DbWeight::get().writes(1)); | ||
|
|
||
| continue; |
There was a problem hiding this comment.
Nice! I think this fixes the issue of having "holes" in the queue.
cdamian
merged commit a437056
into
fix/gateway-message-processing
12 of 13 checks passed
cdamian
added a commit
that referenced
this pull request
Oct 9, 2024
* lp-gateway: Update message recovery comment * lp-gateway: Use transactional in MessageProcessor implementation * lp-gateway: Iterate over inbound sub-messages only during execution * lp-gateway: Add session ID check for message entries * lp-gateway: Use defensive weight during message recovery * lp-gateway: Make MessageProcessor implementation transactional * lp-gateway-queue: Use when checking servicing weight * lp-gateway: Move import * lp-gateway-queue: Remove extra weight check * lp-gateway-queue: Get ordered MessageQueue keys and iterate over them * lp-gateway: Add session ID change tests * lp-gateway: Drop support for inbound batch messages * lp-gateway-queue: Ensure messages are processed in order (#1992) * lp-gateway-queue: Ensure messages are processed in order * lp-gateway-queue: Ensure processed messages are skipped * integration-tests: Remove receipt check * pallet: Rename event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the comment regarding LP gateway queue message processing:
#1991 (comment)